Fix .dockerignore ignoring the .cog directory we produce #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check the docker ignore for .cog and if it exists remove it.
* Make sure we pass this case to prevent .cog docker ignore from sending unusual error messages
There was a problem hiding this comment.
what we really want is for the dockerignore to look like this:
.cog
!.cog/tmp/<current build id>
the one annoying thing about that is that it means the dockerignore will keep changing, which would add noise to diffs if committed to git. it would best if there was an --extra-dockerignore flag to docker build (or similar), but I don't think that exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.dockerignorefile to make sure it doesn't contain the.cogfolder.Fixes: #1961