Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Policy violation Binary Artifacts #14721

Closed
allstar-app bot opened this issue Mar 18, 2022 · 11 comments
Closed

Security Policy violation Binary Artifacts #14721

allstar-app bot opened this issue Mar 18, 2022 · 11 comments
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:refactor Refactoring or improving of existing code

Comments

@allstar-app
Copy link

allstar-app bot commented Mar 18, 2022

This issue was automatically created by Allstar.

Security Policy Violation
Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description
Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps
To remediate, remove the generated executable artifacts from the repository.

Artifacts Found

  • lib/modules/manager/gradle-wrapper/fixtures/expectedFiles/gradle/wrapper/gradle-wrapper.jar
  • lib/modules/manager/gradle-wrapper/fixtures/testFiles-copy/gradle/wrapper/gradle-wrapper.jar
  • lib/modules/manager/gradle-wrapper/fixtures/testFiles/gradle/wrapper/gradle-wrapper.jar

Additional Information
This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.


This issue will auto resolve when the policy is in compliance.

Issue created by Allstar. See https://github.com/ossf/allstar/ for more information. For questions specific to the repository, please contact the owner or maintainer.

@allstar-app allstar-app bot added the allstar label Mar 18, 2022
@rarkins
Copy link
Collaborator

rarkins commented Mar 18, 2022

@JamieMagee @viceice do you think we're justified in ignoring it?

@JamieMagee
Copy link
Contributor

Maybe...

If yes, we might open an issue upstream asking if we can configure ignore patterns. If no, we should see if there is an alternative to having gradle files in the repo

@viceice
Copy link
Member

viceice commented Mar 18, 2022

We should ignore them.

@HonkingGoose
Copy link
Collaborator

If yes, we might open an issue upstream asking if we can configure ignore patterns. If no, we should see if there is an alternative to having gradle files in the repo

There are issues asking for ignore lists already:

@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code status:requirements Full requirements are not yet known, so implementation should not be started labels Mar 18, 2022
@rarkins
Copy link
Collaborator

rarkins commented Mar 18, 2022

Seems like testdata is or was a magic name they ignore: ossf/scorecard#1256 (comment)

Maybe we could make __fixtures__/testdata/ ?

@allstar-app
Copy link
Author

allstar-app bot commented Mar 19, 2022

Updating issue after ping interval. Status:
Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description
Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps
To remediate, remove the generated executable artifacts from the repository.

Artifacts Found

  • lib/modules/manager/gradle-wrapper/fixtures/expectedFiles/gradle/wrapper/gradle-wrapper.jar
  • lib/modules/manager/gradle-wrapper/fixtures/testFiles-copy/gradle/wrapper/gradle-wrapper.jar
  • lib/modules/manager/gradle-wrapper/fixtures/testFiles/gradle/wrapper/gradle-wrapper.jar

Additional Information
This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.

2 similar comments
@allstar-app
Copy link
Author

allstar-app bot commented Mar 21, 2022

Updating issue after ping interval. Status:
Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description
Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps
To remediate, remove the generated executable artifacts from the repository.

Artifacts Found

  • lib/modules/manager/gradle-wrapper/fixtures/expectedFiles/gradle/wrapper/gradle-wrapper.jar
  • lib/modules/manager/gradle-wrapper/fixtures/testFiles-copy/gradle/wrapper/gradle-wrapper.jar
  • lib/modules/manager/gradle-wrapper/fixtures/testFiles/gradle/wrapper/gradle-wrapper.jar

Additional Information
This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.

@allstar-app
Copy link
Author

allstar-app bot commented Mar 22, 2022

Updating issue after ping interval. Status:
Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description
Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps
To remediate, remove the generated executable artifacts from the repository.

Artifacts Found

  • lib/modules/manager/gradle-wrapper/fixtures/expectedFiles/gradle/wrapper/gradle-wrapper.jar
  • lib/modules/manager/gradle-wrapper/fixtures/testFiles-copy/gradle/wrapper/gradle-wrapper.jar
  • lib/modules/manager/gradle-wrapper/fixtures/testFiles/gradle/wrapper/gradle-wrapper.jar

Additional Information
This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.

@rarkins
Copy link
Collaborator

rarkins commented Mar 22, 2022

FYI I've now suspended this app due to the noise caused by this false positive

@rarkins rarkins closed this as completed Mar 22, 2022
@viceice
Copy link
Member

viceice commented Mar 22, 2022

You can also simply remove subscription hen no more notifications will be sent. 😅

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2022
@JamieMagee
Copy link
Contributor

I spoke with @jeffmendoza, and it should now1 be possible to set an ignore list of files. If I am reading the documentation correctly, we need to add a .allstar/allstar.yaml file with the content:

IgnorePaths:
  - ...
  - ...

Footnotes

  1. https://github.com/ossf/allstar/pull/176

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:refactor Refactoring or improving of existing code
Projects
None yet
Development

No branches or pull requests

4 participants