-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Readwise API into its own sdk project #7
Comments
I'm taking a Building a Second Brain course, and there was a session with the folks from Readwise. I asked:
And they answered:
|
Is the thought to make this a separate package on like NPM? Or extract in a different sense? |
For testing, I think we could use a combination of:
I'm going to start a branch to start playing with those ideas. |
Most likely, this is due to them working on their own Readwise plugin
That is something I am considering. The idea of extracting to a separate API would be the best route IMO. There is another Readwise plugin, that it has an API that already supports this features, see here. |
Would you be able to use that client? There is not a license in the repository unfortunately. @jsonMartin any chance of adding a license to your repository? |
Hey @technicalpickles , sure thing. Just went ahead and added a MIT license to the repo 👍 |
That's great, thanks! I took a closer look, and the only thing that would need to change in the library is that it uses |
Trying to drop the API in as is within minimal modifcation was probably overly optimistic 🤔 What I'm thinking now is to:
I don't know how much time I'm going to be put towards it and on what time scale, but I will keep this issue updated. |
@technicalpickles Sounds good. If you start working on a separate repo for the Readwise API, share it here. I can contribute to it after finishing with the improvements left for v0.1 |
This would allow to more easily:
page_size
valueThe text was updated successfully, but these errors were encountered: