Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[videos] Review/update module #14

Open
raucao opened this issue Apr 14, 2013 · 4 comments
Open

[videos] Review/update module #14

raucao opened this issue Apr 14, 2013 · 4 comments
Assignees

Comments

@raucao
Copy link
Member

raucao commented Apr 14, 2013

Please review the current code, update if necessary, remove log statements (or use the remoteStorage debug logger instead). Also, please format the code properly: 2 spaces indentation, add blank lines where needed, remove trailing whitespace, etc.

@ghost ghost assigned silverbucket Apr 14, 2013
@silverbucket
Copy link
Member

sure, what should i do after that? whats the system to get it into master?

@silverbucket
Copy link
Member

also, I had tests assosciated with both the videos and tags modules. (using teste https://github.com/silverbucket/teste/) how should we include tests for modules?

@raucao
Copy link
Member Author

raucao commented Apr 14, 2013

  1. Start a pull request whenever you want to start getting it into master. We can then comment on the lines and add more commits on the way.
  2. Good question! I was just thinking about that, and there's nothing at all in place or planned yet. We should probably use the same harness for all tests, so that it's easy to copy them and add more. Want to maybe add your tests and do it in a way that makes it possible to add others the same way, and probably with naming conventions?

@michielbdejong
Copy link
Member

@silverbucket do you want to add the videos module to master? The test framework is in place now; can you add the videos (and tags) test suites you mentioned? Can I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants