-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RemoveAlwaysTrueIfConditionRector with array_push is buggy #8860
Labels
Comments
We use phpstan to detect type, on phpstan, it is detected as falsy, I think it should be reported there on phpstan side, see https://phpstan.org/r/73565769-6b97-48b7-8b52-e3b8883a5961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
RemoveAlwaysTrueIfConditionRector removes a correct if statement.
Code is quite ugly. It seems the problem is with:
rector remove the if statement:
Expected Behaviour
Rule should not be executed/change code
The text was updated successfully, but these errors were encountered: