Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message "Cannot start workflow" #286

Open
alintulu opened this issue Apr 2, 2020 · 3 comments · May be fixed by reanahub/reana-client#447 or reanahub/reana-commons#240
Open

Error message "Cannot start workflow" #286

alintulu opened this issue Apr 2, 2020 · 3 comments · May be fixed by reanahub/reana-client#447 or reanahub/reana-commons#240
Assignees

Comments

@alintulu
Copy link
Member

alintulu commented Apr 2, 2020

After creating a rather large workflow (uploaded around 200 files) I get one of the two following error messages when trying to run it

$ reana-client run
Cannot start workflow workflow.6: 
60 per 1 minute

$ reana-client run
Cannot start workflow workflow.7: 
1000 per 1 hour
@diegodelemos
Copy link
Member

Currently, each file upload is a REST API call, which would always hit any reasonable REST API rate limit with many files workflows. The idea exposed in reanahub/reana-client#406 about uploading the whole analysis workspace to REANA seems like the long term solution for this issue:

Uploading too many files at the same might be problematic for the server. A good strategy to alleviate this can be packaging the whole directory in a tarball and upload it.

So to address this issue we have to:

@tiborsimko
Copy link
Member

We could amend the reana-client to respect the rate limits a bit better on the client side:

  • when uploading directories with many files, do some sleep() between them because we know this can cause troubles;
  • even better, when seeing the rate limiter message in the response for any REST API call, do not give up but rather retry after N seconds.

@diegodelemos
Copy link
Member

Currently, none of the Invenio App rate-limiting configurations is set (see here). This causes the default rate-limiting values to be loaded causing the problem described in this issue.

We could either use Invenio-App's capability of rate-limiting or looking into Traefik's rate-limiting.

To avoid the problem at hand we could have, apart from the REANA-Client fix, no rate-limiting by default in the server side, setting it only on demand if provided as Helm config.

diegodelemos pushed a commit to diegodelemos/reana-server that referenced this issue Nov 23, 2020
diegodelemos pushed a commit to diegodelemos/reana-server that referenced this issue Nov 23, 2020
diegodelemos pushed a commit to diegodelemos/reana-server that referenced this issue Nov 23, 2020
diegodelemos pushed a commit to diegodelemos/reana-server that referenced this issue Nov 23, 2020
diegodelemos pushed a commit to diegodelemos/reana-server that referenced this issue Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants