Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QuickJournal #3401

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Update QuickJournal #3401

merged 7 commits into from
Aug 2, 2023

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Jul 28, 2023

Updated QuickJournal example to use it as a base for the sync version

  • Added theme, icon and splash screen
  • Added stylecop
  • Updated packages (including Realm)
  • Simplified pages and viewmodels name (no need to repeat "Journal" all the time)
  • Removed unused fonts, images
  • Enabled nullability
  • Verified it still works on iOS, Android and Mac as before. Still black splash screen issue on iOS though
  • Removed tizen

If we want to make any modifications to how the app works/features, this is a good time 😁

I think it's simple enough to provide a good example. The only part that I don't like very much is the use of the Messaging because of the bug in MAUI (that has been solved in version 8, coming out in November). This is used in EntriesViewModel to delete an entry if the user deleted both the title and the body. We could remove this functionality to simplify this example.

@papafe papafe added the no-changelog Used to skip the changelog check label Jul 28, 2023
@coveralls
Copy link

coveralls commented Jul 28, 2023

Pull Request Test Coverage Report for Build 5736736559

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 82.68%

Files with Coverage Reduction New Missed Lines %
Realm/Realm/Exceptions/RealmException.cs 2 78.95%
Realm/Realm/Handles/SessionHandle.cs 3 84.72%
Totals Coverage Status
Change from base Build 5686656271: -0.06%
Covered Lines: 6203
Relevant Lines: 7364

💛 - Coveralls

@papafe papafe merged commit a8a2854 into main Aug 2, 2023
11 checks passed
@papafe papafe deleted the fp/quickjournal-update branch August 2, 2023 08:49
papafe added a commit that referenced this pull request Aug 2, 2023
* main:
  Add new subscribe API (#3403)
  Update QuickJournal (#3401)
  Add a few tests for uncovered code (#3405)
  Update to Core 13.17.1 (#3404)
  Use modern-er marshaling techniques (#3261)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants