Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate LocalAppName and LocalAppVersion #3387

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Deprecate LocalAppName and LocalAppVersion #3387

merged 2 commits into from
Jul 20, 2023

Conversation

nirinchev
Copy link
Member

Description

Fixes #

TODO

  • Changelog entry
  • Tests (if applicable)

@cla-bot cla-bot bot added the cla: yes label Jul 20, 2023
@nirinchev nirinchev requested a review from papafe July 20, 2023 17:20
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5614015035

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 82.582%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Sync/AppConfiguration.cs 2 85.19%
Totals Coverage Status
Change from base Build 5610779526: -0.04%
Covered Lines: 6151
Relevant Lines: 7309
💛 - Coveralls

@nirinchev nirinchev merged commit 3ddb108 into main Jul 20, 2023
79 checks passed
@nirinchev nirinchev deleted the ni/local-app-name branch July 20, 2023 19:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@papafe papafe Awaiting requested review from papafe

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nirinchev @coveralls