Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep track of async open tasks #3386

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Keep track of async open tasks #3386

merged 3 commits into from
Jul 21, 2023

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Jul 20, 2023 •
edited
Loading

Description

Fixes #3344

TODO

  • Changelog entry
  • Tests (if applicable)

@cla-bot cla-bot bot added the cla: yes label Jul 20, 2023
@nirinchev nirinchev requested a review from papafe July 20, 2023 16:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5613815332

  • 5 of 10 (50.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 82.525%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Native/NativeCommon.cs 0 1 0.0%
Realm/Realm/Handles/AsyncOpenTaskHandle.cs 5 9 55.56%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Native/NativeCommon.cs 1 32.56%
Realm/Realm/Handles/SubscriptionSetHandle.cs 3 95.41%
Totals Coverage Status
Change from base Build 5610779526: -0.09%
Covered Lines: 6163
Relevant Lines: 7326
💛 - Coveralls

@nirinchev nirinchev merged commit fbbb556 into main Jul 21, 2023
2 checks passed
@nirinchev nirinchev deleted the ni/async-open-task branch July 21, 2023 10:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@papafe papafe papafe approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unity Editor Crash
3 participants
@nirinchev @coveralls @papafe