Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit messages that contain parentheses get strange highlighting #64

Closed
TamaMcGlinn opened this issue Oct 9, 2021 · 2 comments
Closed

Comments

@TamaMcGlinn
Copy link
Contributor

We've both known about this issue a long time, but I always thought it was unavoidable with the way vim's highlighting works. Turns out that's not the case! Have a look at this fugitive issue, in which various workarounds are implemented by adding special characters which are then hidden in the buffer. Hopefully we can copy the approach to work for vim-flog.

@rbong
Copy link
Owner

rbong commented Oct 9, 2021

I support this idea, but I also gave it a shot myself when I first wrote Flog and abandoned it because of added complexity and not-very-promising early performance tests and settled on something very simple. You could probably even resolve parentheses issues via more robust regex. Like you said I knew about this issue, but didn't give it too much attention.

I might give it a shot again myself, but I'm interested in experimenting with some potential neovim-only highlighting features, so I'm more likely to focus on that. I only ask that if you work on this issue, please make it optional for now. I am not the biggest fan of hidden characters in VIM.

@rbong
Copy link
Owner

rbong commented Jan 26, 2023

Duplicate of #66 , and I already added more details there

@rbong rbong closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants