Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plural for compass API response #150

Open
mabdh opened this issue Jun 21, 2022 · 0 comments
Open

Use plural for compass API response #150

mabdh opened this issue Jun 21, 2022 · 0 comments
Assignees

Comments

@mabdh
Copy link
Member

mabdh commented Jun 21, 2022

Is your feature request related to a problem? Please describe.
In compass API, we use data field as a field that wrap results of GET API. Although the idea was to make all GET API having the same scaffolding of API response (since it will also be translated to REST response with grpc-gateway) but this might not be that flexible for future use cases. Having plural names of the type of results would make it more future-proof.

repeated Asset assets = 1;

Describe the solution you'd like
Update the response fields to use plural names instead of data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants