Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP Update Module #71

Open
Akkarinage opened this issue Jun 14, 2016 · 5 comments
Open

CP Update Module #71

Akkarinage opened this issue Jun 14, 2016 · 5 comments

Comments

@Akkarinage
Copy link
Member

Originally, the FluxAdmin module showed the latest FluxCP commits and PRs, along with information about the latest commits to rA too. On my version that I never managed to publish, was a backup and update feature.

Backup was pretty simple; the CP would create a .zip of itself containing all files and SQL data. It was meant to help users who needed to move their website from one host to another.

Update feature literally updated FluxCP to the latest version available on Github. This had two methods, one button ran similar to exec('git stash && git pull && git stash pop'); while the other would download a tag and unpack. The install screen would be shown if new sql data needed creating.

Essentially this was designed to save users time and effort updating. It became abit useless since no real updates were being produced at the time but i still used it to check on commits on FluxCP and rA (mine had rA git update code as site was on same vps as server, which is the other main reason it was never released).

Thoughts?

@aleos89
Copy link
Contributor

aleos89 commented Jun 14, 2016

This would be a cool feature for future use anyways! Many web based services use this method now so I see no reason why we can't have something like that. :)

@FlippAcademy
Copy link

I think this would be an awesome addition. From my previous experience, uploading / upgrading certain tables always threw some sort of error when you go through the install / update process. This would make things a little bit more seamless.

@Vennren
Copy link

Vennren commented Oct 9, 2016

This feature would be a welcome addition. Even if it just would show the updates available that would be sufficient, but making it a one-click-update system would appeal the masses more.

Were you also meaning to add the rA update feature? If that was also the idea, I think it would also be a welcome addition.

@KeiroD
Copy link

KeiroD commented Nov 6, 2016

I'd definitely include this module so that FluxCP admins can update their copies when they're able to. Honestly, this is pretty much a must these days.

@Akkarinage
Copy link
Member Author

Just a quick update; I've begun to work on this. It could take a few days, it could take a few months.

There are currently 3 Pull Requests that will either be merged or dismissed as the last set of changes to our version of FluxCP before the Update module is introduced. All future code pushed to github will be obtainable via the Update module with a single button click. Nice and easy.

There will be several things that server owners need to keep in-mind before beginning to use this process:

  • As changes are made, the 'default' theme will constantly be overwritten. Your custom theme should be in it's own folder and using the correct structure. See the theme documentation first.
  • Designers need to stop releasing new themes in the 'default' folder. Any themes that include old versions of FluxCP listed on rAthena will be removed. Just .zip your theme dir. That's all you need to provide. Stop making people's lives difficult. Thanks.
  • Some users change things in the /modules/ directory. Your changes will need to be introduced as a new addon module to prevent future changes from being overwritten. We will be providing appropriate documentation for this before the Update module is released.
  • No one will need to play around in the /config/ directory, and most of the files in this dir will be vanishing. The other files will remain there as default settings and your customisations will be written to a cache. You will be able to modify the settings of your FluxCP installation via the Admin Dashboard.

There are many users who seem to think they can just go changing code willy-nilly because they know a little php, but in most cases this has introduced bad coding standards, vulnerabilities and headaches for people who actually get hired to clear up someone elses mess.

The module will essentially keep the entire CP in a single state, where customisations to the core code are removed. You will need to keep your customisations in the appropriate place, as this is how FluxCP is designed.

More details and instructions on how to migrate your existing installations will be made available closer to the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New Items
Development

No branches or pull requests

5 participants