common: utils: Respect provided stride #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naushir
reviewed
Dec 12, 2023
src/libpisp/common/pisp_utils.cpp
Outdated
| @@ -67,7 +67,8 @@ void compute_stride_align(pisp_image_format_config &config, int align) | |||
| if (PISP_IMAGE_FORMAT_compressed(config.format)) | |||
| width = (width + 7) & ~7; // compression uses blocks of 8 samples | |||
|
|
|||
| config.stride = compute_x_offset(config.format, width); | |||
| if (!config.stride) | |||
| config.stride = compute_x_offset(config.format, width); | |||
There was a problem hiding this comment.
I wonder if this is not entirely safe, and we should perhaps do something like:
uint32_t computed_stride = compute_x_offset(config.format, width);
if (!config.stride || config.stride < computed_stride)
config.stride = computed_stride;
will-v-pi
force-pushed
the
respect_stride
branch
from
019fbfe
to
1ffc4ac
Compare
When computing stride alignment, don't overwrite a provided stride unless the stride provided is too small.
will-v-pi
force-pushed
the
respect_stride
branch
from
1ffc4ac
to
824acbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing stride alignment, don't overwrite a provided stride.