Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSEGOG-129 save sessions #249

Merged
merged 16 commits into from
Aug 3, 2023
Merged

DSEGOG-129 save sessions #249

merged 16 commits into from
Aug 3, 2023

Conversation

joshuadkitenge
Copy link
Contributor

@joshuadkitenge joshuadkitenge commented May 30, 2023 •
edited by louise-davies
Loading

Description

  • A user should be able to create a user session filling out a dialog form that is opened by clicking the add Icon located in the drawer.
  • The save and save as buttons are added as placeholder in this PR function will be added into a later PR.

Testing instructions

  • Check that the request body send to the backend matches the current state of the website

  • Check the error handling in the dialog

  • Review code

  • Check Actions build

  • Review changes to test coverage

  • {more steps here}

Agile board tracking

closes DSEGOG-129

@joshuadkitenge
Copy link
Contributor Author

save-session-1

@codecov
Copy link

codecov bot commented Jun 15, 2023 •
edited
Loading

Codecov Report

Patch coverage: 98.71% and project coverage change: +0.07% 🎉

Comparison is base (03aec18) 95.69% compared to head (7821306) 95.77%.
Report is 48 commits behind head on develop.

❗ Current head 7821306 differs from pull request most recent head c8e6741. Consider uploading reports for the commit c8e6741 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #249      +/-   ##
===========================================
+ Coverage    95.69%   95.77%   +0.07%     
===========================================
  Files           71       75       +4     
  Lines         3093     3170      +77     
  Branches       885      897      +12     
===========================================
+ Hits          2960     3036      +76     
- Misses         131      132       +1     
  Partials         2        2
Files Changed Coverage Δ
src/app.types.tsx 100.00% <ø> (ø)
src/state/store.tsx 90.90% <83.33%> (-9.10%) ⬇️
src/api/sessions.tsx 100.00% <100.00%> (ø)
src/search/searchBar.component.tsx 100.00% <100.00%> (ø)
src/session/saveSessionDialogue.component.tsx 100.00% <100.00%> (ø)
src/session/sessionButtons.component.tsx 100.00% <100.00%> (ø)
src/session/sessionDrawer.component.tsx 100.00% <100.00%> (ø)
src/views/viewTabs.component.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuadkitenge
Copy link
Contributor Author

add save session

@joshuadkitenge joshuadkitenge marked this pull request as ready for review July 28, 2023 08:43
louise-davies
louise-davies requested changes Aug 3, 2023
View reviewed changes
Copy link
Member

@louise-davies louise-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine other than one comment I had re: a text field.

louise-davies
louise-davies approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@louise-davies louise-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuadkitenge joshuadkitenge merged commit 0776323 into develop Aug 3, 2023
2 checks passed
@joshuadkitenge joshuadkitenge deleted the DSEGOG-129-save-sessions branch August 3, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louise-davies louise-davies louise-davies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuadkitenge @louise-davies