Add Expected Lifetime to Catalogue Items #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TODO: check mock-data test file #338
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #393 +/- ##
========================================
Coverage 97.86% 97.87%
========================================
Files 41 41
Lines 1502 1504 +2
========================================
+ Hits 1470 1472 +2
Misses 32 32 ☔ View full report in Codecov by Sentry. |
…dels to forward migration #338
joelvdavies
requested changes
Oct 17, 2024
joelvdavies
reviewed
Oct 17, 2024
inventory_management_system_api/migrations/scripts/expected_lifetime_migration.py
Outdated
Show resolved
Hide resolved
4 tasks
joelvdavies
reviewed
Oct 17, 2024
inventory_management_system_api/migrations/scripts/expected_lifetime_migration.py
Show resolved
Hide resolved
joelvdavies
reviewed
Oct 17, 2024
inventory_management_system_api/migrations/scripts/expected_lifetime_migration.py
Outdated
Show resolved
Hide resolved
inventory_management_system_api/migrations/scripts/expected_lifetime_migration.py
Outdated
Show resolved
Hide resolved
VKTB
approved these changes
Oct 18, 2024
joelvdavies
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
This can be safely merged prior to ral-facilities/inventory-management-system#1020 if you wish. The extra field will just be ignored.
asuresh-code
deleted the
add-expected-lifetime-field-to-cataolgue-items-#338
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enter a description of the changes here
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #338