Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when extra keys are dropped #7

Open
rafd opened this issue Apr 22, 2020 · 0 comments
Open

Warn when extra keys are dropped #7

rafd opened this issue Apr 22, 2020 · 0 comments

Comments

@rafd
Copy link
Owner

rafd commented Apr 22, 2020

Currently, if a tada event is passed parameters with more keys than a spec defines, it silently drops those extra keys (using spec-tools' coercion). This is fine, because it helps avoid potential security issues (similar to how Rails controllers handle parameters). However, in development, this can be confusing.

Suggestion:

  • in development, return an appropriate anomaly and warning message for extra keys
  • consider whether the error message should be different in production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant