Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fspec for event conditions #1

Open
jamesnvc opened this issue Sep 25, 2019 · 0 comments
Open

Use fspec for event conditions #1

jamesnvc opened this issue Sep 25, 2019 · 0 comments

Comments

@jamesnvc
Copy link
Collaborator

There is a spec defined for the event conditions, but it currently isn't being used. This is because when the spec is defined, we just know that the params will be a map, but when it's actually invoked, we know that the params will have conformed to the params spec. This means that when the spec generates test cases, it will generate invalid data, which the function is justified in failing for.

Ideally, the conditions spec could dynamically depend on the params spec, so this could be used. However, there would probably have to be some way (possibly metadata) to prevent the function from being generatively tested, since it might be undesirable to have it repeatedly called with test data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant