Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tab alignments are broken in right-to-left languages #847

Open
largestgithubuseronearth opened this issue Oct 20, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed important

Comments

@largestgithubuseronearth

Describe the bug
When using right-to-left languages and the FGT, the Tab titles are too far to the left side of the tab width and the spinner widget is not visible. Additionally, the "refresh" blue swell that comes over a tab when it's finished loading is also misaligned.

To Reproduce

  1. Have FGT installed
  2. Open Firefox and go into Settings. In General, go to Languages, click the dropdown and "Search for more languages".
  3. Click "Select Language to Add" and select any right-to-left language, then click Add. In this example, I'm using Persian ( فارسی ) but I tried a couple others and got the same issues.
  4. Restart Firefox to see the error in the Tabs.

Expected behavior
When using a right-to-left language, the Tab titles would remain center-aligned, and the Tab loading spinner would be visible.

Video example

Screencast.From.2024-10-20.12-40-44.mp4

Setup information

  • OS: Arch, Fedora 40
  • Installation method: Package manager, Flatpak
  • Firefox version: v131.0.3
  • Theme tag version: v131

Additional context
The original issue I got for this

@rafaelmardojai
Copy link
Owner

Yeah, I have never tested rtl langs and never cared about using the writing mode/directionality aware spacing/alignment CSS properties. In newer code I do try to used them, but for old code it may stay like that until I find some time.

@rafaelmardojai rafaelmardojai added help wanted Extra attention is needed important labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed important
Projects
None yet
Development

No branches or pull requests

2 participants