-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO-1557 / Support Network Gateway #29
Conversation
Test Results44 tests +7 31 ✔️ +5 17s ⏱️ -6s Results for commit 794b2be. ± Comparison against base commit bff6a76. This pull request removes 4 and adds 11 tests. Note that renamed tests count towards both.
This pull request skips 2 tests.
♻️ This comment has been updated with latest results. |
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
@@ -0,0 +1,66 @@ | |||
version: '3.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need another file? We were constructing the standalone configuration based on the node config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shambupujar It is possible to use the same file.
My concern was that the template could become to complex when adding more if/else that would stop the core node and nginx from starting.
New Features:
Includes refactoring for: