Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cases vignette #93

Open
e-kotov opened this issue Oct 3, 2024 · 4 comments · May be fixed by #94
Open

use cases vignette #93

e-kotov opened this issue Oct 3, 2024 · 4 comments · May be fixed by #94
Labels
documentation Improvements or additions to documentation

Comments

@e-kotov
Copy link
Member

e-kotov commented Oct 3, 2024

@Robinlovelace do we want to update/review/rename/repurpose/extend the https://ropenspain.github.io/spanishoddata/articles/uses.html vignette before the first release?

@e-kotov e-kotov added this to the first stable release milestone Oct 3, 2024
@e-kotov e-kotov added the documentation Improvements or additions to documentation label Oct 3, 2024
@Robinlovelace
Copy link
Collaborator

I don't see any major issues with it, see it as more of a placeholder for us to add more use cases as they appear, with links to other stuff. Seeing as the package is quite new and not out there yet there are not loads of use cases which is unsurprising.

@Robinlovelace
Copy link
Collaborator

Open to ideas though so, turning this around, does anyone else have suggested changes to it?

@e-kotov
Copy link
Member Author

e-kotov commented Oct 17, 2024

One concern is that "odjitter NOTE: This project is deprecated. Please use od2net directly to generate route networks from OD data." ( https://github.com/dabreegster/odjitter )

Other is perhaps I would rename it to what it is right now - the vignette on using origin destination data for disaggregation. If we add any extra use cases, we may create some index page for all of them in the articles section of the package website.

Finally, I would perhaps only keep this as article and exclude from vignettes, as we will have a lot of headache with non-CRAN packages in the vignette (I guess).

@Robinlovelace
Copy link
Collaborator

👍 to both suggestions, move to an article and state that it's about geo disaggregation of the od data, that could be useful for many use cases.

@Robinlovelace Robinlovelace linked a pull request Oct 18, 2024 that will close this issue
@Robinlovelace Robinlovelace linked a pull request Oct 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants