Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addPopupIframes() unexported status? #31

Open
asadow opened this issue May 10, 2024 · 1 comment
Open

addPopupIframes() unexported status? #31

asadow opened this issue May 10, 2024 · 1 comment

Comments

@asadow
Copy link

asadow commented May 10, 2024

I found addPopupIframes() through #20. I was curious whether it is still being developed for export?

While using it, I noticed a few things:

a warning would be nice to have if the object supplied to source is less (or greater?) than the length of the data referenced in the group. It causes some unexpected behaviour.
it's missing the ... arg, which allows for position

@asadow asadow changed the title addPopupIframes() addPopupIframes() unexported status? May 10, 2024
@tim-salabim
Copy link
Member

Good points, let me see what I can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants