Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess a fix to segfault issue #577

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Contributor

For #567.

cc @mcol / @struckma -- can you test if this change removes the segfault for you? I'm still hamstrung by being unable to reproduce the segfault outside GHA.

Also cc @krlmlr who filed & followed the orginal Buganizer report & workaround kludge here.

@mcol
Copy link

mcol commented Sep 25, 2024

I've run our testsuite with a freshly-compiled covr with your patch applied, and unfortunately it doesn't help: running time was 68 minutes (it's around 7-8 minutes on 4.3.3).

@MichaelChirico
Copy link
Contributor Author

Alas. IMO the next thing to do is try "bisecting" the package itself to see if it's a certain piece of code that's responsible. Unfortunately for data.table, the issue is most likely related to `[.data.table` which is ~2000 lines long and probably used in >80% of tests... not very friendly for bisection :\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants