From 48dd01bee4f082240cec21e9dedb31fb476d9229 Mon Sep 17 00:00:00 2001
From: Bruno Tremblay <bruno@boostao.ca>
Date: Thu, 31 Aug 2023 14:30:51 -0400
Subject: [PATCH] Modify `odbcDataType.Snowflake` to better reflect Snowflake
 Data Types documentation

---
 NEWS.md       |  2 ++
 R/DataTypes.R | 10 +++++-----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/NEWS.md b/NEWS.md
index a6075841..669d95d5 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,5 +1,7 @@
 # odbc (development version)
 
+* Modify `odbcDataType.Snowflake` to better reflect Snowflake Data Types documentation (@meztez, #599).
+
 # odbc 1.3.5
 
 * Various fixes for `R CMD check`.
diff --git a/R/DataTypes.R b/R/DataTypes.R
index 69cf23d1..0be9ec96 100644
--- a/R/DataTypes.R
+++ b/R/DataTypes.R
@@ -300,16 +300,16 @@ odbcDataType.Oracle <- function(con, obj, ...) {
 `odbcDataType.Snowflake` <- function(con, obj, ...) {
   switch_type(
     obj,
-    factor = "VARCHAR(255)",
+    factor = "VARCHAR",
     datetime = "TIMESTAMP",
     date = "DATE",
     time = "TIME",
-    binary = "VARBINARY(255)",
+    binary = "BINARY",
     integer = "INTEGER",
-    double = "DOUBLE PRECISION",
-    character = "VARCHAR(255)",
+    double = "FLOAT",
+    character = "VARCHAR",
     logical = "BOOLEAN",
-    list = "VARCHAR(255)",
+    list = "VARCHAR",
     stop("Unsupported type", call. = FALSE)
   )
 }