-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply proper RAII to Connection #439
Comments
We have |
This issue is renamed to reflect that it's not just the homeserver but basically the whole login session identity that has to be preserved within a given |
This is a very bad idea generally, and the current code will leave quite a few things on the floor if
setHomeserver()
gets called while jobs fly over. And there's no real case for it either; so just forbid it by design. Ideally, the whole server resolution/setting could be a couple of static factories so thatConnection
would always be created with a sane homeserver set up; but that contradicts to the currently accustomed usage of Connection as a QML component. Maybe when we get a ConnectionManager singleton in Quotient it will be possible to shape the library API in a better way.The text was updated successfully, but these errors were encountered: