From a9693cbe5cbce55e5dfadae773976dabfec88b94 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Mon, 8 Jul 2024 02:41:16 +0100 Subject: [PATCH] [WIP] Build: Try adding back old iOS/Android to BS matrix --- .github/workflows/browsers-debug.yaml | 48 +++++++++++++++++++++++++++ build/browserstack-debug.json | 28 ++++++++++++++-- build/browserstack-full.json | 31 ----------------- 3 files changed, 74 insertions(+), 33 deletions(-) create mode 100644 .github/workflows/browsers-debug.yaml diff --git a/.github/workflows/browsers-debug.yaml b/.github/workflows/browsers-debug.yaml new file mode 100644 index 000000000..353cdac14 --- /dev/null +++ b/.github/workflows/browsers-debug.yaml @@ -0,0 +1,48 @@ +name: browsers-debug +on: + # Or manually + workflow_dispatch: + # Or when developing this workflow + push: + paths: + - .github/workflows/browsers-debug.yaml + - build/browserstack-debug.json + +jobs: + run: + name: BrowserStack + if: ${{ github.repository == 'qunitjs/qunit' }} # skip on forks, needs secret + runs-on: ubuntu-latest + env: + PUPPETEER_DOWNLOAD_PATH: "${{ github.workspace }}/.puppeteer_download" + steps: + - uses: actions/checkout@v4 + + - uses: actions/cache@v4 + with: + path: | + ~/.npm + ${{ github.workspace }}/.puppeteer_download + key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }} + + - name: Use Node.js 18 + uses: actions/setup-node@v4 + with: + node-version: 18.x + + - name: Prepare + run: | + npm ci + npm run build + + - name: Tests + run: npm run browserstack + env: + BROWSERSTACK_JSON: build/browserstack-debug.json + BROWSERSTACK_USERNAME: "${{ secrets.BROWSERSTACK_USERNAME }}" + BROWSERSTACK_KEY: "${{ secrets.BROWSERSTACK_KEY }}" + # Set "project" metadata + TRAVIS_REPO_SLUG: "${{ github.repository }} ${{ github.event_name }}" + # Set "commit" metadata + TRAVIS_COMMIT: "full ${{ github.ref }} ${{ github.sha }}" + TUNNEL_ID: "${{ github.event_name }}-full-${{ github.sha }}" diff --git a/build/browserstack-debug.json b/build/browserstack-debug.json index be31d9cbc..48c0c8b47 100644 --- a/build/browserstack-debug.json +++ b/build/browserstack-debug.json @@ -5,7 +5,31 @@ "exit_with_fail": true, "timeout": 600, "browsers": [ - "firefox_current", - "chrome_current" + { + "os": "android", + "os_version": "7.0", + "device": "Samsung Galaxy S8", + "real_mobile": true, + }, + { + "os": "android", + "os_version": "5.0" + }, + { + "os": "ios", + "os_version": "11.0" + }, + { + "os": "ios", + "os_version": "10.3" + }, + { + "os": "ios", + "os_version": "9.3" + }, + { + "os": "ios", + "os_version": "8.3" + } ] } diff --git a/build/browserstack-full.json b/build/browserstack-full.json index 253961770..6dd5fa14f 100644 --- a/build/browserstack-full.json +++ b/build/browserstack-full.json @@ -45,36 +45,5 @@ "os": "ios", "os_version": "12" } - ], - "@browsers_disabled": [ - { - "@ref": [ - "https://github.com/browserstack/browserstack-runner/issues/245", - "Android 4, Android 5, Android 6" - ] - }, - { - "@ref": [ - "https://github.com/browserstack/browserstack-runner/issues/226", - "Android 7-10", - "iOS 13, 14" - ] - }, - { - "device": "Samsung Galaxy S7", - "real_mobile": true, - "os": "android", - "os_version": "6.0" - }, - { - "device": null, - "os": "ios", - "os_version": "13" - }, - { - "device": null, - "os": "ios", - "os_version": "14" - } ] }