Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultStreamer doesn't take inline:true into account for large data sets #88

Open
jogoussard opened this issue Nov 20, 2017 · 0 comments

Comments

@jogoussard
Copy link

jogoussard commented Nov 20, 2017

ResultStreamer.java.txt
According to http://docs.qubole.com/en/latest/rest-api/command_api/view-command-results.html, a response can contain "inline": true while still having the results in S3. The simple inline test done in ResultStream#getResults needs to be expanded into:
boolean isInline = resultValue.isInline();
if (resultValue.getResult_location() != null && resultValue.getResult_location().size() > 0)
{
isInline = false;
}
if (isInline)
{
return new StringReader(resultValue.getResults());
}

    return readFromS3(resultValue.getResult_location());

I have a fix for this, but can't push my branch for review (not authorized) - file attached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant