Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAF::Service: Providing restart-if-running (conditional restart) functionality. #251

Open
jrha opened this issue Sep 14, 2017 · 4 comments

Comments

@jrha
Copy link
Member

jrha commented Sep 14, 2017

Rather than components having to handle this individually, see quattor/configuration-modules-core#1167 for example.

@stdweird
Copy link
Member

if it is not implemented by the service, should we bother?
systemd has cond-restart, but i do not know how it handles sysvinit scripts.

@jrha
Copy link
Member Author

jrha commented Sep 14, 2017

Well indeed.

@gombasg
Copy link
Contributor

gombasg commented Sep 14, 2017

Well-behaved SysV init scripts should also implement condrestart. The information about which service supports which action should live in OS-specific templates, not in the components. What CAF::Service could do is accept a mapping between requested actions to supported actions; template code could then describe that "well, you may only want to reload the configuration, but the version shipped by the OS only understands restart", or even things like "the restart action is known to be broken, do a distinct stop followed by a start instead".

@jrha
Copy link
Member Author

jrha commented Oct 25, 2017

Discussed at RAL workshop: agreed to add support for condrestart but not work around any lack of functionality for SysV init scripts - up to admins to understand if the underlying service support it or not.

@jrha jrha changed the title CAF::Service: Consider providing restart-if-running functionality. CAF::Service: Providing restart-if-running (conditional restart) functionality. Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants