Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't count qpsolvers matrix build times in solver times #12

Open
stephane-caron opened this issue Nov 7, 2022 · 0 comments
Open

Don't count qpsolvers matrix build times in solver times #12

stephane-caron opened this issue Nov 7, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@stephane-caron
Copy link
Member

stephane-caron commented Nov 7, 2022

Currently we time solvers externally, so that the timing will include both matrix build and solve times. This is done in qpbenchmark/utils.py by, essentially:

start_time = perf_counter()
solution = qpsolvers.solve_problem(problem, solver=solver)
runtime = perf_counter() - start_time

Separating build and solve times would allow a more fair comparison. It should be done upstream in qpsolvers: qpsolvers/qpsolvers#255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant