Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNAFASTAFormat and AlignedDNAFASTAFormat should check for duplicate ids during full validation #198

Open
gregcaporaso opened this issue Nov 6, 2018 · 0 comments
Open

DNAFASTAFormat and AlignedDNAFASTAFormat should check for duplicate ids during full validation #198

gregcaporaso opened this issue Nov 6, 2018 · 0 comments

Comments

@gregcaporaso
Copy link
Member

Improvement Description
Multi-record fasta formats (like DNAFASTAFormat and AlignedDNAFASTAFormat) could check to ensure that there are no duplicate records so developers working with these formats don't have to.

Current Behavior
These formats can contain duplicate records.

Proposed Behavior
If full validation of a format was requested, it could raise an error if the same sequence identifier is observed multiple times.

References
This came up in the context of qiime2/q2-alignment#54 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregcaporaso