Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Envelope type public #1054

Closed
stavros11 opened this issue Sep 20, 2024 · 1 comment
Closed

Make Envelope type public #1054

stavros11 opened this issue Sep 20, 2024 · 1 comment
Milestone
Qibolab 0.2.0

Comments

@stavros11
Copy link
Member

I wonder whether we should make this public, and reintroduce this comment (here or somewhere else).

It is true that it is annotated with Envelope, but that's the base class, while the other one is the enumeration...

However, this is definitely not for 0.2.0

Originally posted by @alecandido in #1053 (comment)
@alecandido alecandido added this to the Qibolab 0.2.1 milestone Sep 20, 2024
@stavros11
Copy link
Member Author

In the end it was already public and the comment was reintroduced in 49133dc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Qibolab 0.2.0
Development

No branches or pull requests
2 participants
@alecandido @stavros11