-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Build - not building missing Qsci/qscimod6.sip #59134
Comments
Could you try deleting the folder ... p.s. sorry, that would require a build with dependencies, I'll follow up with a PR soon. Not sure yet if this dolves the problem though |
@m-kuhn , would you be changing something in the QGIS source, or something in the QGIS Master SDK? I am working on trying to get a build of QGIS on Windows 11 and it feels like I am really close. |
In the SDK (which is produced from the vcpkg subfolder in QGIS) Do you find a file |
@m-kuhn yes, here. C:\QGIS\vcpkg-export-20241015-154141\installed\x64-windows-release\tools\python3\Lib\site-packages\PyQt6\bindings\Qsci |
@m-kuhn do you need me to delete or replace this file? Just let me know and happy to try whatever is needed here. |
can you run C:\QGIS\vcpkg-export-20241015-154141\installed\x64-windows-release\tools\python3\python.exe -c "import os; import PyQt6; print(os.path.dirname(PyQt6.__file__), end='') |
and ideally, if you could run |
I am not yet sure where exactly that problem is originating from, so this is just debugging so far. |
I am running the Build command on the VS solution for the project that is failing, but let me go out and run this command and I'll get you output. |
C:>C:\QGIS\vcpkg-export-20241015-154141\installed\x64-windows-release\tools\python3\python.exe -c "import os; import PyQt6; print(os.path.dirname(PyQt6.file), end='') |
Hmm.. thinking out loud here.. does this need to be added to the Environment Variables in Windows as part of the path? |
No, that's not needed. This is a python internal mechanism to look for dlls in this path. |
The only thing that I found in the solution and this was in the QGIS\CMakeLists.txt I am not seeing any reference to ${PYQT6_SIP_DIR} anywhere, so I am not sure where this is getting set. Is this read in from somewhere? |
If you could add a line
Just there, we would also get our answer |
Everything in the build is contained within the "build" folder that is created using the screenshot I posted above. I am wondering if that parameter needs to be set as part of that cmake above that sets the SDK path. I am not building the base CMake, but the solution that's been built out. Also, also, I did a grep on the QGIS folder and this is all I found. |
|
from where? root of the build solution? or root of the source directory? |
I basically had it search everything looking for that.. cmake files included as well as basically anything not binary. |
This thing outputted like a couple of thousand lines, but am guessing you are looking for this portion..
|
So, it looks like I played around with it and got it to resolve that dependency. I ended up copying the Qsci folder from the vcpkg folder structure under "C:\Program Files\Python313\Lib\site-packages\PyQt6\bindings" and then it ended up resolving that dependency. However, now I am on to the next issue after this resolved. I can open another issue or we can keep going in this thread. Seems like it would be good to know why copying the folder worked when it was pointing to the other folder. However, these looks somewhat related. 2. |
oh, it looks like there are some leftovers from system python (not the one in the SDK), possibly an env variable
do you still have the |
oops, yes I do and forgot about that. With building the solution, does it still reference that makefile? Taking out just in case.. Thanks for pointing that out and I'll remove and see what happens. Also, greatly appreciate your help working through this... ty very much. |
In summary: to me this seems to be a local issue, without more information here that could lead to an improvement inside QGIS, I would close this. |
@m-kuhn, thanks again for your assistance on this. So, question regarding the python setup. I had to install python along with sip, pyqt6 and a couple of other things as part of the process to get the project this far. Should I have been able to point everything to the vcpkg sdk and not have to do this? Also, and I am going to open another issue, but I am putting custom build options for a few projects in the solution and it appears that something is overwriting them and creating compiler issues. A few projects need the /bigobj compiler option to build, but something appears to be randomly removing it. is there a place I can force this to be set to where when it is overwritten, it contains the additional compiler option? |
yes |
@m-kuhn there were no instructions for that in the Install.md file. If this was something that was supposed to happen by passing the SDK path into it, it feels like something didn't get set right. My initial try was without python installed and it was throwing all sorts of missing python(proper) and dependencies. was this another parameter that needs to be added on the cmake for vcpkg? |
No instructions to not do something? 😜 It should have just worked, if it didn't I'd have to see an error message to say more |
Does this mean anything to you?
[cid:fde993fb-b04e-4f96-ae2e-fab567b9a3d7]
It looks like it's trying to load some plugins, but not exactly what this is expecting or how to fix it.
…________________________________
From: Matthias Kuhn ***@***.***>
Sent: Tuesday, October 22, 2024 5:09 PM
To: qgis/QGIS ***@***.***>
Cc: danodom-tcb ***@***.***>; Author ***@***.***>
Subject: Re: [qgis/QGIS] Windows Build - not building missing Qsci/qscimod6.sip (Issue #59134)
No instructions to not do something? 😜
It should have just worked, if it didn't I'd have to see an error message to say more
—
Reply to this email directly, view it on GitHub<#59134 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMHU5D5BQ6CTM3DSMD4XCHTZ42BDRAVCNFSM6AAAAABQGTAORCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZHAZDANJTHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
What is the bug or the crash?
I have followed the recently updated instructions and have installed a # of python packages, but getting the following error on building the python_module_qgis__gui project. At this point, I am not sure how to resolve this dependency in the solution. I have all of the other 500+ projects building successfully in Visual Studio 2022.
4>sip-build: C:\QGIS\QGIS\build\python\gui\gui.sip: line 15: column 9: 'Qsci/qscimod6.sip' could not be found
4>C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build for 'C:\QGIS\QGIS\build\python\gui\gui.sip' exited with code 1.
4>Done building project "python_module_qgis__gui.vcxproj" -- FAILED.
Steps to reproduce the issue
Build the "qgis"solution built after running the following commands with the corresponding values.
We assume you have a copy of the QGIS source code available
and have changed the working directory into it
Configure
cmake -S .
-B build
-DSDK_PATH="path/to/vcpkg-export-[date]"
-DBUILD_WITH_QT6=ON
-DWITH_QTWEBKIT=OFF
-DVCPKG_TARGET_TRIPLET=x64-windows-release
Versions
I am unable to get to the help menu as the error is occurring during the build (@jef-n thank you for updating the install.md recently as I am getting close to building QGIS on Windows 11 and just need some help getting to the finish line.
Supported QGIS version
New profile
Additional context
No response
The text was updated successfully, but these errors were encountered: