Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wheel tags command displays invalid filenames on stdout #632

Open
MKuranowski opened this issue Aug 8, 2024 · 0 comments · May be fixed by #641
Open

wheel tags command displays invalid filenames on stdout #632

MKuranowski opened this issue Aug 8, 2024 · 0 comments · May be fixed by #641

Comments

@MKuranowski
Copy link

MKuranowski commented Aug 8, 2024 •
edited
Loading

To quote python -m wheel tags --help:

The output filename(s) will be displayed on stdout for further processing.

This should make usage in shell scripts like FIXED_WHEEL_PATH=$(python -m wheel tags ...) (with single input file) possible.

However, instead, the stdout is spammed with "added: 'module/some/file.py'" lines, which are not valid filenames. Such logging should be sent to stderr instead.

Example output of `python -m wheel tags` 
$ python -m wheel tags --python-tag py3 --abi-tag none --platform-tag manylinux2014_x86_64.manylinux_2_17_x86_64 dist/impuls-0.6.0-cp312-cp312-linux_x86_64.whl 2>/dev/null
adding 'impuls-0.6.0.dist-info/METADATA'
adding 'impuls-0.6.0.dist-info/WHEEL'
adding 'impuls/extern/libextern.so'
adding 'impuls/extern/__init__.py'
adding 'impuls/model/meta/__init__.py'
adding 'impuls/model/meta/entity.py'
adding 'impuls/model/meta/sql_builder.py'
adding 'impuls/model/meta/utility_types.py'
adding 'impuls/model/__init__.py'
adding 'impuls/model/agency.py'
adding 'impuls/model/attribution.py'
adding 'impuls/model/calendar_exception.py'
adding 'impuls/model/calendar.py'
adding 'impuls/model/fare_attribute.py'
adding 'impuls/model/fare_rule.py'
adding 'impuls/model/feed_info.py'
adding 'impuls/model/frequency.py'
adding 'impuls/model/route.py'
adding 'impuls/model/shape_point.py'
adding 'impuls/model/stop.py'
adding 'impuls/model/stop_time.py'
adding 'impuls/model/transfer.py'
adding 'impuls/model/translation.py'
adding 'impuls/model/trip.py'
adding 'impuls/tasks/__init__.py'
adding 'impuls/tasks/add_entity.py'
adding 'impuls/tasks/exec_sql.py'
adding 'impuls/tasks/generate_trip_headsign.py'
adding 'impuls/tasks/load_busman.py'
adding 'impuls/tasks/load_gtfs.py'
adding 'impuls/tasks/merge.py'
adding 'impuls/tasks/modify_from_csv.py'
adding 'impuls/tasks/remove_unused_entities.py'
adding 'impuls/tasks/save_db.py'
adding 'impuls/tasks/save_gtfs.py'
adding 'impuls/tasks/truncate_calendars.py'
adding 'impuls/tools/__init__.py'
adding 'impuls/tools/color.py'
adding 'impuls/tools/geo.py'
adding 'impuls/tools/iteration.py'
adding 'impuls/tools/logs.py'
adding 'impuls/tools/machine_load.py'
adding 'impuls/tools/polish_calendar_exceptions.py'
adding 'impuls/tools/strings.py'
adding 'impuls/tools/temporal.py'
adding 'impuls/tools/testing_mocks.py'
adding 'impuls/tools/types.py'
adding 'impuls/__init__.py'
adding 'impuls/app.py'
adding 'impuls/db.py'
adding 'impuls/errors.py'
adding 'impuls/multi_file.py'
adding 'impuls/options.py'
adding 'impuls/pipeline.py'
adding 'impuls/py.typed'
adding 'impuls/resource.py'
adding 'impuls/task.py'
adding 'impuls-0.6.0.dist-info/RECORD'
impuls-0.6.0-py3-none-manylinux2014_x86_64.manylinux_2_17_x86_64.whl
MKuranowski added a commit to MKuranowski/Impuls that referenced this issue Aug 8, 2024
@MKuranowski
Workaround garbage wheel tags output
ce6ce3c 
See pypa/wheel#632.
agronholm added a commit that referenced this issue Nov 7, 2024
@agronholm
Only configure setuptools logging if bdist_wheel is imported
f65bcc2 
Also fix the output of `wheel convert` to add the final "OK" on the same line as the source file name.

Fixes #632.
@agronholm agronholm linked a pull request Nov 7, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only configure setuptools logging if bdist_wheel is imported pypa/wheel
1 participant
@MKuranowski