Added font-awesome-based icons #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
- Coverage 95.95% 95.92% -0.04%
==========================================
Files 59 60 +1
Lines 3340 3358 +18
Branches 638 639 +1
==========================================
+ Hits 3205 3221 +16
- Misses 96 98 +2
Partials 39 39 ☔ View full report in Codecov by Sentry. |
JWCook
requested changes
Jun 12, 2024
There was a problem hiding this comment.
Since this isn't currently used by any other library features, could you move all the Font Awesome-related code from constants.py to the new module font_awesome_icons.py?
| } | ||
|
|
||
| assert set(ICONIC_TAXA.keys()) == set(ICONIC_EMOJI.keys()) | ||
| assert set(ICONIC_TAXA.keys()) == set(ICONIC_FONT_AWESOME.keys()) |
There was a problem hiding this comment.
Could you remove these asserts? Those should generally only be used in unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, adds suppory for font-awesome-based icons matched with the emojis to the best of my abilities. This is simply added as additional consts dictionaries.
Closes #553