Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rotation matrix from orthonormal base #85

Open
berendkleinhaneveld opened this issue Jan 18, 2024 · 2 comments
Open

Add rotation matrix from orthonormal base #85

berendkleinhaneveld opened this issue Jan 18, 2024 · 2 comments

Comments

@berendkleinhaneveld
Copy link

berendkleinhaneveld commented Jan 18, 2024 •
edited
Loading

Maybe call it mat_from_axes?
@Korijn
Copy link
Contributor

Korijn commented Jan 18, 2024 •
edited
Loading

We could. It would be trivial (arr = np.eye(4); arr[:3, :3] = axes), but there's value in defining the convention (rows vs columns).

Any other special requirements? For example, automatic pre-normalization of the input axes, or forced orthogonality?

@berendkleinhaneveld
Copy link
Author

berendkleinhaneveld commented Jan 18, 2024 •
edited
Loading

Your examples sound good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@berendkleinhaneveld @Korijn