Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode Theme #138

Closed
Bashamega opened this issue May 4, 2024 · 5 comments · Fixed by #139
Closed

Dark Mode Theme #138

Bashamega opened this issue May 4, 2024 · 5 comments · Fixed by #139
Assignees
Labels
enhancement New feature or request

Comments

@Bashamega
Copy link
Contributor

Is your feature request related to a problem? Please describe.
No, my feature request is not related to a problem. My idea is to add a dark mode theme similar to the one in the docs

I would like to work on this

@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented May 4, 2024

Hi, @Bashamega – thanks for the request. The theme that we use does have a dark mode now, and it has been something that has been on my plate since some while. It will be great to update the submodule for the theme and update the website accordingly to account for any broken pages. Happy to assign you to this as you mentioned – the goal would be to resemble the NumPy and SciPy websites.

@agriyakhetarpal agriyakhetarpal added the enhancement New feature or request label May 4, 2024
@Bashamega
Copy link
Contributor Author

Helllo @agriyakhetarpal :)
Since the new update of the theme doesn't have a short code for notice, I was thinking of replacing them with the hint admonition. You can see an example here: https://theme.scientific-python.org/shortcodes/
What do you think?

@agriyakhetarpal
Copy link
Member

Sure, the hint admonition should work. Also, we can review further when we have a deployment preview ready.

@Bashamega
Copy link
Contributor Author

Sure, the hint admonition should work. Also, we can review further when we have a deployment preview ready.

Ok

@Bashamega
Copy link
Contributor Author

I think this issue should be closed

@agriyakhetarpal agriyakhetarpal linked a pull request May 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants