Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing the parameters for the optical flow calculation #376

Open
ladc opened this issue Jul 15, 2024 · 9 comments
Open

Optimizing the parameters for the optical flow calculation #376

ladc opened this issue Jul 15, 2024 · 9 comments
Assignees

Comments

@ladc
Copy link
Contributor

ladc commented Jul 15, 2024

[RMI/ KNMI / site specific] Is more better, and how to check this?
Number of frames, other parameters

@ladc
Copy link
Contributor Author

ladc commented Jul 15, 2024

This can be done using ray as suggested by @dnerini

see example: https://colab.research.google.com/drive/1pMAJZ8AZe7gUDgCogenfdlc-ayX6kVVM?usp=sharing

@ladc
Copy link
Contributor Author

ladc commented Jul 15, 2024

Lukas-Kanade from openCV provides some uncertainty information about the u,v components, can we use this?

@dnerini
Copy link
Member

dnerini commented Jul 15, 2024

see example: https://colab.research.google.com/drive/1pMAJZ8AZe7gUDgCogenfdlc-ayX6kVVM?usp=sharing

if possible, one by product of this issue could be adding this example as a tutorial to the pysteps documentation

@aitaten
Copy link
Contributor

aitaten commented Jul 16, 2024

Hi!! As I mentioned yday ... I implemented in this example the INCA motion which uses the errors of previous nowcating to correct the latest kind-of-TREC motion vector computation. It uses numba but I am not sure this is required as a new library in pySTEPS but maybe we can think if these errors are useful for task 8 (velocity perturbation settings) or can help in optimizing the optical flow calculation. Here is the link to the example

@dnerini
Copy link
Member

dnerini commented Jul 17, 2024

Hi!! As I mentioned yday ... I implemented in this example the INCA motion which uses the errors of previous nowcating to correct the latest kind-of-TREC motion vector computation. It uses numba but I am not sure this is required as a new library in pySTEPS but maybe we can think if these errors are useful for task 8 (velocity perturbation settings) or can help in optimizing the optical flow calculation. Here is the link to the example

wouldn't this be rather a new feature to be implemented?

@aitaten
Copy link
Contributor

aitaten commented Jul 18, 2024

Hi!! As I mentioned yday ... I implemented in this example the INCA motion which uses the errors of previous nowcating to correct the latest kind-of-TREC motion vector computation. It uses numba but I am not sure this is required as a new library in pySTEPS but maybe we can think if these errors are useful for task 8 (velocity perturbation settings) or can help in optimizing the optical flow calculation. Here is the link to the example

wouldn't this be rather a new feature to be implemented?

I am not sure if you want me to implement these things in pySTEPS or not. I think the kind-of-TREC (using numba, so adding this dependency thing you mentioned) can be implemented in motion sublibrary. The previous nowcast errors computation and the introduction of those into the final vector motion can be also added but I am not sure the best place to do so. So any recommendation is welcome 😄 The think is that can be done and also understood as a correction to the error vector (so again in motion sublibrary) or as a preprocessing step (feature sublibrary). Also, in operations, this is not the way is done ... these errors are saved from the previous time steps. And last but not least, do we want to introduce the NWP wind correction as well?

@aitaten
Copy link
Contributor

aitaten commented Jul 19, 2024

Hi!! So, this is the link to the colab code. Can @dnerini tell me if I should link it in the repo or upload the notebook?
And @sidekock, please have a look at let me know what would you change in the explanation 🤝

@dnerini
Copy link
Member

dnerini commented Jul 19, 2024

thanks! essentially the colab needs to be exported as jupyter notebook (.ipynb) and saved in the examples/ folder, same as with the my_first_nowcast.ipynb file. Rember to clear all output cells before exporting the jupyter from colab.

Then we can link it in the docs, same as the existing tutorial, see here:

My first nowcast (Colab Notebook) <https://colab.research.google.com/github/pySTEPS/pysteps/blob/master/examples/my_first_nowcast.ipynb>

All this can be done in one PR, can you open one? I'll be happy to review it!

@sidekock
Copy link
Contributor

Looks good. Maybe we can change Note to Caution? It's a bit more alerting, no? But this is a very minor comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

4 participants