Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flawed logic for get/set/delete attribute #72

Open
rsb-23 opened this issue Oct 15, 2024 · 0 comments
Open

Flawed logic for get/set/delete attribute #72

rsb-23 opened this issue Oct 15, 2024 · 0 comments

Comments

@rsb-23
Copy link

rsb-23 commented Oct 15, 2024

base.py : if name not in self.normal_attributes and name.lower() == name:

Issue : This logic is based on the letter-case of the instance variables along with exception for normal_attributes.

Impact:

  1. Makes modification to VBase and sub-classes challenging.
  2. Can't implement linters with default or minimal settings.
  3. Adds to technical debt

Expectation: To use a logic which clearly denotes the actual business requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant