From 5f901693c88abf2f2644965741fd27fb00baca52 Mon Sep 17 00:00:00 2001
From: Cooper Ry Lees <me@cooperlees.com>
Date: Tue, 24 Oct 2023 10:45:54 -0700
Subject: [PATCH] Fix lints + add git to release CI

- Remove black + mypy as linting already runs it ...
- Ignore delete param to TemporaryDirectory as we can't set mypy to 3.12 :D
---
 .github/workflows/release_tests.yml | 15 +++++----------
 release.py                          |  2 +-
 release_tests.py                    |  7 ++++---
 3 files changed, 10 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/release_tests.yml b/.github/workflows/release_tests.yml
index 352ade59e2b..ca7c351c894 100644
--- a/.github/workflows/release_tests.yml
+++ b/.github/workflows/release_tests.yml
@@ -32,6 +32,11 @@ jobs:
       - name: Print Python Version
         run: python --version --version && which python
 
+      - name: Installing git CLI tool
+        run: |
+          sudo apt update
+          sudo apt install git
+
       - name: Update pip, setuptools + wheels
         run: |
           python -m pip install --upgrade pip setuptools wheel
@@ -41,13 +46,3 @@ jobs:
           python -m pip install coverage
           coverage run release_tests.py
           coverage report -m
-
-      - name: Run mypy strict
-        run: |
-          python -m pip install mypy
-          mypy --strict release.py
-
-      - name: Run black preview
-        run: |
-          python -m pip install black
-          black --preview release*
diff --git a/release.py b/release.py
index f55864a1a0c..167af92d529 100755
--- a/release.py
+++ b/release.py
@@ -133,7 +133,7 @@ def cleanup_changes_template_for_release(self) -> None:
             "## Unreleased", f"## {self.next_version}"
         )
 
-        # Remove all comments (subheadings are harder - Human will still need to do them)
+        # Remove all comments (subheadings are harder - Human required still)
         no_comments_changes = []
         for line in versioned_changes.splitlines():
             if line.startswith("<!--"):
diff --git a/release_tests.py b/release_tests.py
index f7ca9be03c2..d2e2c494364 100644
--- a/release_tests.py
+++ b/release_tests.py
@@ -13,17 +13,18 @@
 class FakeDateTime:
     """Used to mock the date to test generating next calver function"""
 
-    def today(*args: Any, **kwargs: Any) -> "FakeDateTime":
+    def today(self, *args: Any, **kwargs: Any) -> "FakeDateTime":
         return FakeDateTime()
 
     # Add leading 0 on purpose to ensure we remove it
-    def strftime(*args: Any, **kwargs: Any) -> str:
+    def strftime(self, *args: Any, **kwargs: Any) -> str:
         return "69.01"
 
 
 class TestRelease(unittest.TestCase):
     def setUp(self) -> None:
-        self.tempdir = TemporaryDirectory(delete=False)
+        # We only test on >= 3.12
+        self.tempdir = TemporaryDirectory(delete=False)  # type: ignore
         self.tempdir_path = Path(self.tempdir.name)
         self.sf_real_black_repo = SourceFiles(Path(__file__).parent)
         self.sf = SourceFiles(self.tempdir_path)