Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] report PRs that bring down type coverage #17

Open
azjezz opened this issue Aug 3, 2020 · 1 comment
Open

[Feature Request] report PRs that bring down type coverage #17

azjezz opened this issue Aug 3, 2020 · 1 comment

Comments

@azjezz
Copy link
Contributor

azjezz commented Aug 3, 2020

A recent PR I made to PSL, lowered the type coverage from 100% to 99%, and I didn't notice until after it got merged and I saw the badge. while the fix was pretty easy ( 00602d71 ), I would have rather the CI failed in the PR or at least shepherd bot commented to alert about the type coverage decrease.

@azjezz azjezz changed the title [Feature Request] report PR that bring down type coverage [Feature Request] report PRs that bring down type coverage Aug 3, 2020
@paulshryock
Copy link

I like the idea of a coverage threshold which would fail builds if Psalm coverage was below the threshold... something like vendor/bin/psalm --coverage --coverageThreshold=100... but that seems like more of a job for Psalm than for the Shepherd package. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants