Skip to content
This repository has been archived by the owner on Mar 13, 2021. It is now read-only.

Change Stream.provider from string to ObjectRef #80

Closed
ericbottard opened this issue Sep 16, 2019 · 2 comments
Closed

Change Stream.provider from string to ObjectRef #80

ericbottard opened this issue Sep 16, 2019 · 2 comments

Comments

@ericbottard
Copy link
Contributor

No description provided.

@ericbottard ericbottard changed the title Change Stream.provider from stream to ObjectRef Change Stream.provider from string to ObjectRef Sep 16, 2019
@scothis
Copy link
Member

scothis commented Sep 16, 2019

Let's hold off on this one. There are significant complexity and usability concerns introduced by using an ObjectReference, that I don't think are worth the benefit have have different providers with the same name.

  1. tools (or users) creating a stream need to know about the specific provisions types API Group and kind (like streaming.projectriff.io/v1alpha1 and KafkaProvider)
  2. the controller reconciling the stream needs RBAC permissions, duck types and a rest client to be able to get/watch the provider type

@ericbottard
Copy link
Contributor Author

Closing in favor of #86 to keep loose coupling

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants