Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support both batch and single mode for LengthDelimitedStream #1365

Open
eriktaubeneck opened this issue Oct 22, 2024 · 0 comments
Open

support both batch and single mode for LengthDelimitedStream #1365

eriktaubeneck opened this issue Oct 22, 2024 · 0 comments

Comments

@eriktaubeneck
Copy link
Member

          one of the big challenges I've had thus far is how to reason about `enc_reports` and how it could interact with reshard. but collection all of these into a stream solves that and makes it much easier to deal with.

I wonder if we should consider hiding some of that complexity "under the hood" in LengthDelimitedStream and have it operate like a "normal" stream that where .next() gives an individual item, and not a Vec. not in scope for this PR, but curious of others opinions here.

Originally posted by @eriktaubeneck in #1362 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant