-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPA runs with 3M input fails with ZKP batcher assertion error #1308
Comments
@andyleiserson pointed out that we could set the batch size to an artificially large number (1B) to get past this error. let validator = sh_ctx.dzkp_validator(
MaliciousProtocolSteps {
protocol: &Step::Aggregate,
validate: &Step::AggregateValidate,
},
// 1B batch size, suboptimal. But only to test that it works for 3M
1 << 30,
); I did that and got past 3M, but the same error (maybe from a different callsite) occurs at 4M |
|
^ that was a false alarm, I was running draft on main. With some other fixes, we are getting to 25M but there is another error 2024-09-25T01:04:01.190427 - 2024-09-25T01:04:01.190370Z INFO oprf_ipa_query{sz=25000000}:compute_prf_for_inputs: ipa_core::protocol::context::batcher: is_ready_for_validation: batch 190 is ready for validation
2024-09-25T01:04:11.257442 - query_id='6d647286-1f06-4d9f-9502-ad751c91d4e3' running. tailing log file.
2024-09-25T01:04:13.252435 - 2024-09-25T01:04:13.252364Z INFO oprf_ipa_query{sz=25000000}:compute_prf_for_inputs: ipa_core::protocol::context::batcher: is_ready_for_validation: batch 191 is ready for validation
2024-09-25T01:04:13.292487 - 2024-09-25T01:04:13.292422Z INFO oprf_ipa_query{sz=25000000}:compute_prf_for_inputs: ipa_core::protocol::context::dzkp_validator: validating 52428800 multiplications
2024-09-25T01:04:21.762627 - 2024-09-25T01:04:21.762551Z INFO oprf_ipa_query{sz=25000000}:compute_prf_for_inputs: ipa_core::protocol::context::batcher: is_ready_for_validation: batch 192 is ready for validation
2024-09-25T01:04:21.765495 - 2024-09-25T01:04:21.762674Z ERROR oprf_ipa_query{sz=25000000}:compute_prf_for_inputs: ipa_core::error: ThreadId(42) "query_runtime" panicked at ipa-core/src/protocol/context/step.rs:33:10:
2024-09-25T01:04:21.790548 - Step index 192 out of bounds for DzkpBatchStep with count 192. Consider using bounds-checked step constructors.
2024-09-25T01:04:21.791032 - stack trace:
this seems like we underestimated the number of steps we need to run malicious validation |
You can increase that back to 256, or even higher. This is #1269. I don't think it's so much that we underestimated the number of steps, it was just a convenient shortcut at the time. |
Link to the run: https://draft-mpc.vercel.app/query/view/adult-sum2024-09-23T1639
The text was updated successfully, but these errors were encountered: