Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gemini models #222

Closed
NimJay opened this issue Apr 15, 2024 · 3 comments
Closed

Add support for Gemini models #222

NimJay opened this issue Apr 15, 2024 · 3 comments

Comments

@NimJay
Copy link

NimJay commented Apr 15, 2024

Describe the feature

  • This is a feature request to add support for Google's Gemini models.
  • I'm mainly creating this GitHub issue to first check if the owners of this repository are open to having Gemini support. :)
    • (I personally would want to try out this repo using Google's Gemini models.)

Potential Solutions

Related documentation

@klieret klieret added ✨ enhancement New feature or request ➕ feature ▼ prio: low Low priority and removed ✨ enhancement New feature or request labels Apr 15, 2024
@ofirpress
Copy link
Member

Yup, this would be great to have, we welcome contributions on this.

@klieret
Copy link
Member

klieret commented Apr 15, 2024

@NimJay Could you check if we could add the new model via litellm? We're slowly starting to accumulate a lot of models/code in models.py and perhaps slowly migrating some of them to use litellm might allow us to simplify (also see #64). For the models that are used in the paper, we need to be extra careful to replicate the cost function etc., so let's perhaps test this for new models first.

Disclaimer: I haven't looked too closely at litellm, so feel free to let me know if this would make things more/equally complicated instead of simplifying things under one common interface.

@klieret klieret removed the ▼ prio: low Low priority label Apr 15, 2024
@ofirpress
Copy link
Member

We're going to add support for something like LiteLLM therefore this issue will be deprecated. Closing.

@ofirpress ofirpress closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants