Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems to copy files outside of basepath #177

Open
bkno opened this issue Oct 20, 2022 · 1 comment
Open

Seems to copy files outside of basepath #177

bkno opened this issue Oct 20, 2022 · 1 comment

Comments

@bkno
Copy link

bkno commented Oct 20, 2022

I'm seeing a strange result with the below config:

require('postcss-url')({
    url: 'copy',
    basePath: path.resolve('node_modules'),
    assetsPath: 'assets/images'
    useHash: true
}),

Upon debug, bathPath is evaluated (as expected) as project_root/node_modules.

Images are not being copied from project_root/node_modules/some_lib/an_image.gif as I want however it is only copying images referenced in CSS from project_root/css into project_root/dist/assets/images.

I.e. the basePath seems to do the opposite of what it should be doing. Can anyone please explain why it is doing this?

@ppodgorsek
Copy link

ppodgorsek commented Jun 6, 2024

The postcss-url plugin is meant to process URLs within CSS files. The base path indicates where those URLs should be resolved from. As such, it'll only process the resources referenced in CSS files.

If you would like to copy all images from a specific folder regardless of their use in CSS, I'd suggest looking at other plugins such as:

  • for Webpack: copy-webpack-plugin
  • for Rollup: rollup-plugin-smart-asset

If the issue is that the wrong resources are copied, this could be due to the use of relative URLs, in which case the plugin seems to ignore the base path. For example,

  • url(../images/hello.png) would be resolved from the parent folder
  • url(images/hello.png) would be resolved from the base path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants