Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NearFutureSolar and tweakscale #9

Closed
RealKolago opened this issue Jan 2, 2016 · 4 comments
Closed

NearFutureSolar and tweakscale #9

RealKolago opened this issue Jan 2, 2016 · 4 comments
Labels

Comments

@RealKolago
Copy link

Is there a way to make NearFutureSolar compatible with tweakscale?

@ChrisAdderley
Copy link
Collaborator

You should ask the TweakScale guys about this, I don't support TweakScale myself.

@RealKolago
Copy link
Author

Please take a look here:
http://github.com/pellinor0/TweakScale/issues/6

"I had a look in https://github.com/ChrisAdderley/NearFutureSolar/blob/master/ModuleCurvedSolarPanel.cs

The problem seems to be that TotalEnergyRate is used only once to calculate chargePerTransform, probably this is done before TweakScale tries to scale it. chargePerTransform can not be scaled because it is not a kspField.

In my opinion this is best solved in NF-Solar, by evaluating TotalEnergyRate directly in the fixedUpdate method.

EDIT: I am working on a pull request for NF-Solar"

@ChrisAdderley
Copy link
Collaborator

Will look at verifying this for next version.

@ChrisAdderley
Copy link
Collaborator

Finally fixed in the next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants