From 357b86e4eb679bb0c3590a26f857104d8b679fb3 Mon Sep 17 00:00:00 2001 From: nsiicm0 Date: Fri, 11 Oct 2024 11:04:14 +0200 Subject: [PATCH] Properly namespacing output_id for render.download in order for it to work in modules --- shiny/render/_render.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shiny/render/_render.py b/shiny/render/_render.py index 0486524a2..52578532b 100644 --- a/shiny/render/_render.py +++ b/shiny/render/_render.py @@ -688,7 +688,7 @@ def url() -> str: from urllib.parse import quote session = require_active_session(None) - return f"session/{quote(session.id)}/download/{quote(self.output_id)}?w=" + return f"session/{quote(session.id)}/download/{quote(session.ns(self.output_id))}?w=" # Unlike most value functions, this one's name is `url`. But we want to get the # name from the user-supplied function. @@ -705,7 +705,7 @@ def url() -> str: # have been started. session = get_current_session() if session is not None and not session.is_stub_session(): - session._downloads[self.output_id] = DownloadInfo( + session._downloads[session.ns(self.output_id)] = DownloadInfo( filename=self.filename, content_type=self.media_type, handler=fn,