Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phenotypes with targets missing in extensions #3766

Open
PCarme opened this issue Oct 29, 2024 · 6 comments
Open

Phenotypes with targets missing in extensions #3766

PCarme opened this issue Oct 29, 2024 · 6 comments
Assignees

Comments

@PCarme
Copy link

PCarme commented Oct 29, 2024

I spotted a couple of phenotypes from this paper PMID:19056896 which have the extension "affecting" with no target gene specified.
image
Opening this ticket so I remember to look into it.

@PCarme
Copy link
Author

PCarme commented Nov 11, 2024

This is where the problem comes from
Screenshot 2024-11-11 at 09 51 09

The identifier names used in the "assayed_using" extensions are probably not recognised, right @kimrutherford ?

@ValWood
Copy link
Member

ValWood commented Nov 11, 2024

That's weird, they don't even appear to be extensions that are valid for that term! apart from the odd IDs.
Assign to me and I'll take a look.

@kimrutherford
Copy link
Member

The identifier names used in the "assayed_using" extensions are probably not recognised, right @kimrutherford ?

Yep, it needs to be a gene ID to be recognised.

@PCarme
Copy link
Author

PCarme commented Nov 11, 2024

From my perspective, these annotations should be turned into "decreased histone H3-K9 acetylation at protein coding gene during vegetative growth (FYPO:0007217)" with the target gene IDs as extensions, or maybe into a new FYPO term "decreased histone H3-K9 acetylation at protein coding gene promoter during vegetative growth (FYPO:0007217)"

@ValWood
Copy link
Member

ValWood commented Nov 11, 2024

That sounds right. Could you swithch and request term if necessary.

I have a vague recollection that at one point we decided that promoters should have the IDs with -promoter, but we never fully implemented that! Also your suggestion would be much clearer.

@PCarme
Copy link
Author

PCarme commented Nov 11, 2024

Alright, let's do that. I'll request the new terms, and approve the session with "decreased histone H3-K9 acetylation at protein coding gene during vegetative growth (FYPO:0007217)" with the gene IDs as extensions and "promoter" as a Comment until the new terms get added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants