-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redefinition of skill and language bars to circles or squares within polycvsidebar #7
Comments
AnalysisI have to admit this was nothing I anticipated. The circles and squares are late additions, and didn't make it to the final release of the sidebar. As such, the mechanism is (still) internal and needs to be overwritten explicitly. The culprit is in the following code: polycv/source/latex/polycv.dtx Lines 1989 to 1998 in 0d17e7d
To be honest, I don't exactly know how I came up with this form of template and why I used exactly these lengths. I guess it felt right at the time. This is how the skill is defined and later used in the sidebar: polycv/source/latex/polycv.dtx Lines 2017 to 2022 in 0d17e7d
So you could indeed redefine these commands within the sidebar, since the original definition will be restored at the end: polycv/source/latex/polycv.dtx Lines 2035 to 2036 in 0d17e7d
Current WorkaroundsThis is not as straightforward as for the main body, because there is (currently) no accessible template for a single (skill) line. However, you can define it yourself to whatever you want with quite low-level commands. A very simple reimplementation would be:
For long descriptions this might look odd and brake. More complicated and possibly a little bit more robust:
This would allow for different implementations of skill and language. Alternatively, you can change the internal definition of the command that will be loaded automatically. This will simultaneously effect
Further considerations and developmentI guess the easiest to make this more customisable is to mirror what is happening in the main environment. Since these are not really breaking changes, but additions and internal redefinitions, I assume they can go into a v1.1. |
Added To allow for better customisation of the side bar (#7) a line template. Removed an internal macro and replaced it with several user-level macros. Options to control the new lengths have been added. To do: Extend the user manual with these new commands.
The user-level commands for the sidebar line and the corresponding skill and language templates have been addded to the manual. The options for the hint width and the indentation have also been added. The progressbar linewdith option is documented and described. The examples have been recompiled to check for inconsistencies. This commit should properly complete #7 (after necessary further testing).
The change is now live in the development version. This should be as easy as for the main body: polycv/examples/skill-redefinition-side/main.tex Lines 29 to 32 in 59999d3
Please test this and let me know what you think. |
This workaround is working fine. It does what it's supposed to do. In the same style I also added |
This is already the new implementation, no longer a workaround (which was to redefine the internal commands). I'm not sure, beyond what I have already tested, there is anything left to do. I guess I could escalate this to a release candidate status soon then. |
* Added line template for sidebar Added To allow for better customisation of the side bar (#7) a line template. Removed an internal macro and replaced it with several user-level macros. Options to control the new lengths have been added. * Fixes for progress and level bars The line width for the outline of the progress bar can now be set with the options. It was previously to 'thick', now the default is 0.2 mm. The line thickness is now also used for the symbols in the level bars. The total width of the progress bar now also considers this thickness. This was previously 'accounted for' by scaling the x axis. It will now be properly subtracted. * Documentation for new sidebar line The user-level commands for the sidebar line and the corresponding skill and language templates have been added to the manual. The options for the hint width and the indentation have also been added. The progressbar linewidth option is documented and described. The examples have been recompiled to check for inconsistencies. * Update version and date, recompile and adapted examples, push #7 to RC
Using the
\renewcommand\cvlanguage[2]{\cvline{\levelbarsquares[0.7\linewidth]{#2}}{#1}}
in the preamble is ignored by the progressbars within thepolycvsidebar
environment.What did work was using this command within the sidebar, however this also badly affects the list's format in 2 ways:
I also did some experimenting by manually redefining
\cvlanguage
and\cvskill
and got a similarly bad format (I currently can't find these modifications anymore)Is there a way to redefine the language and skill commands for
polycvsidebar
as well while not keeping the original format?The text was updated successfully, but these errors were encountered: