Update try-runtime-cli #463
Merged
+75
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
commented
Sep 30, 2024
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
TODO paritytech/try-runtime-cli#101 Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
commented
Oct 8, 2024
| @@ -137,7 +137,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| spec_name: create_runtime_str!("statemine"), | |||
| impl_name: create_runtime_str!("statemine"), | |||
| authoring_version: 1, | |||
| spec_version: 1_003_000, | |||
| spec_version: 1_003_003, | |||
There was a problem hiding this comment.
We forgot to bump this and only bumped the feature-gated version above...
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
acatangiu
approved these changes
Oct 12, 2024
seadanda
approved these changes
Oct 14, 2024
ordian
approved these changes
Oct 14, 2024
|
bot merge |
|
/merge |
|
I think it needs another review, my review isn't counted because I'm a rank 1 pleb |
Hm, its weird that the bot is not responding though. It should print some error. |
|
/merge |
|
Enabled Available commands
For more information see the documentation |
1 similar comment
|
Enabled Available commands
For more information see the documentation |
|
https://github.com/polkadot-fellows/runtimes/pull/463/checks?check_run_id=31685484077 |
bkchr
reviewed
Oct 18, 2024
ggwpez
commented
Oct 18, 2024
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
bkchr
approved these changes
Oct 18, 2024
Co-authored-by: Bastian Köcher <[email protected]>
ggwpez
commented
Oct 18, 2024
|
/merge |
|
Enabled Available commands
For more information see the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update try-runtime-cli for MBM testing that was added Allow to test Multi-Block-Migrations paritytech/try-runtime-cli#90
Fix KAH spec version that was incorrectly bumped
Disable MBM testing for Encointer runtime until Fix encointer AURA slot paritytech/try-runtime-cli#101 is fixed (single-block-migrations are still checked).
Does not require a CHANGELOG entry