Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Events] Add missing events #858

Open
5 tasks
bryanchriswhite opened this issue Oct 4, 2024 · 0 comments · Fixed by #867 or #869 · May be fixed by #872
Open
5 tasks

[Events] Add missing events #858

bryanchriswhite opened this issue Oct 4, 2024 · 0 comments · Fixed by #867 or #869 · May be fixed by #872
Assignees
@bryanchriswhite
Labels
application Changes related to the Application actor code health Cleans up some code gateway Changes related to the Gateway actor observability on-chain On-chain business logic supplier Changes related to the Supplier actor
Milestone
Shannon Beta Test...

Comments

@bryanchriswhite
Copy link
Contributor

bryanchriswhite commented Oct 4, 2024 •
edited
Loading

Objective

Add the following missing events:

  • EventApplicationStaked
  • EventApplicationUnbondingBegin
  • EventApplicationUnbondingEnd
  • EventApplicationUnbondingCanceled
  • EventGatewayStaked
  • EventSupplierUnbondingCanceled

Status

Origin Document

image

https://discord.com/channels/553741558869131266/1205594535405817896/1291470839509811200

Goals

  • Ensure actor (un)stake events are observable on the network.

Deliverables

  • A PR for each module with adds the missing events and implements their emissions accordingly.

Non-goals / Non-deliverables

  • Updating any existing events.
  • Refactoring any msg handler or end blocker logic beyond the scope of emitting the new events.

General deliverables

  • Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
  • Testing: Add new tests (unit and/or E2E) to the test suite.
  • Makefile: Add new targets to the Makefile to make the new functionality easier to use.
  • Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @bryanchriswhite
Co-Owners:
@bryanchriswhite bryanchriswhite added application Changes related to the Application actor supplier Changes related to the Supplier actor gateway Changes related to the Gateway actor on-chain On-chain business logic code health Cleans up some code observability labels Oct 4, 2024
@bryanchriswhite bryanchriswhite self-assigned this Oct 4, 2024
@bryanchriswhite bryanchriswhite changed the title [Application] Add unbonding status events [Events] Add missing events Oct 4, 2024
@bryanchriswhite bryanchriswhite mentioned this issue Oct 8, 2024
Merged
15 tasks
@bryanchriswhite bryanchriswhite linked a pull request Oct 8, 2024 that will close this issue
[Application] Add missing (un)staking events #867
Merged
15 tasks
This was referenced Oct 9, 2024
Merged
Open
bryanchriswhite added a commit that referenced this issue Oct 21, 2024
@bryanchriswhite @red-0ne
[Application] Add missing (un)staking events (#867)
c4d8449 
## Summary

Adds:
- `EventApplicationStake`
- `EventApplicationUnbondingBegin`
- `EventApplicationUnbondingEnd`
- `EventApplicationUnbondingCanceled`

Also refactors application min. stake unbonding to re-use existing
unbonding period and end-blocker mechanics instead of unbonding
immediately.

## Issue

- #858

## Type of change

Select one or more from the following:

- [x] New feature, functionality or library
- [ ] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [ ] Bug fix
- [x] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

## Testing

- [ ] **Documentation**: `make docusaurus_start`; only needed if you
make doc changes
- [ ] **Unit Tests**: `make go_develop_and_test`
- [ ] **LocalNet E2E Tests**: `make test_e2e`
- [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.

## Sanity Checklist

- [x] I have tested my changes using the available tooling
- [x] I have commented my code
- [x] I have performed a self-review of my own code; both comments &
source code
- [ ] I create and reference any new tickets, if applicable
- [ ] I have left TODOs throughout the codebase, if applicable

---------

Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: red-0ne <[email protected]>
bryanchriswhite added a commit that referenced this issue Oct 23, 2024
@bryanchriswhite @red-0ne @Olshansk
[Gateway] Add missing stake event (#869)
be96b75 
## Summary

- Adds and emits a new `EventGatewayStaked` event to the gateway module.
- Refactors `EventGatewayUnstaked` to contain the entire gateway and
session end height.
- Adds the shared module keeper as a gateway keeper dependency.

## Issue

- #858

## Type of change

Select one or more from the following:

- [x] New feature, functionality or library
- [ ] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [ ] Bug fix
- [ ] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

## Testing

- [ ] **Documentation**: `make docusaurus_start`; only needed if you
make doc changes
- [ ] **Unit Tests**: `make go_develop_and_test`
- [ ] **LocalNet E2E Tests**: `make test_e2e`
- [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.

## Sanity Checklist

- [x] I have tested my changes using the available tooling
- [x] I have commented my code
- [x] I have performed a self-review of my own code; both comments &
source code
- [ ] I create and reference any new tickets, if applicable
- [ ] I have left TODOs throughout the codebase, if applicable

---------

Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: red-0ne <[email protected]>
This was linked to pull requests Oct 23, 2024
[Gateway] Add missing stake event #869
Merged
[Supplier] Add missing event #872
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryanchriswhite bryanchriswhite

Labels
application Changes related to the Application actor code health Cleans up some code gateway Changes related to the Gateway actor observability on-chain On-chain business logic supplier Changes related to the Supplier actor
Projects
Shannon
Status: 👀 In review
Milestone
Shannon Beta TestNet Launch
1 participant
@bryanchriswhite